-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor TSDB doc_values utils for use in the new codec #115042
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
changed the title
Refactor TSDB doc_values util allow introduce new codec
Refactor tsdb doc_values utils allow introduce new codec
Oct 17, 2024
dnhatn
force-pushed
the
shared-doc-values-util
branch
from
October 17, 2024 19:43
631c259
to
2339ff9
Compare
dnhatn
changed the title
Refactor tsdb doc_values utils allow introduce new codec
Refactor TSDB doc_values utils for use in the new codec
Oct 18, 2024
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @martijnvg. |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Oct 18, 2024
This PR refactors the doc_values utils used in the TSDB codec to allow sharing between the current codec and the new codec.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 19, 2024
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Oct 25, 2024
This PR refactors the doc_values utils used in the TSDB codec to allow sharing between the current codec and the new codec.
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
This PR refactors the doc_values utils used in the TSDB codec to allow sharing between the current codec and the new codec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the doc_values utils used in the TSDB codec to allow sharing between the current codec and the new codec.